Codecov Report

❌ Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.94%. Comparing base (b0d5e79) to head (1f733c9).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #7301      +/-   ##
==========================================
+ Coverage   89.85%   89.94%   +0.08%     
==========================================
  Files         273      275       +2     
  Lines       13773    13999     +226     
==========================================
+ Hits        12376    12591     +215     
- Misses       1397     1408      +11     

I didn't check the exporter parts (OTLP, Console). IMO worth to do this.

EDIT: Separate PR will be fine.

I didn't check the exporter parts (OTLP, Console). IMO worth to do this.

I checked the repo again.

• OTLP writes the value rather than a string, so it already does the right thing and doesn't need formatting special casing:

  opentelemetry-dotnet/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/Serializer/ProtobufOtlpTraceSerializer.cs

  Lines 269 to 282 in 2435127

  	internal static int WriteTraceFlags(byte[] buffer, int position, ActivityTraceFlags activityTraceFlags, bool hasRemoteParent, int fieldNumber)
  	{
  	var spanFlags = (uint)activityTraceFlags & 0x000000FF;
  	spanFlags |= 0x00000100;
  	if (hasRemoteParent)
  	{
  	spanFlags |= 0x00000200;
  	}
  	position = ProtobufSerializer.WriteFixed32WithTag(buffer, position, fieldNumber, spanFlags);
  	return position;
  	}

• Console does ToString() on the enum already, so doesn't need updating and doesn't need to be high-performance.

  opentelemetry-dotnet/src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs

  Line 23 in 2435127

  this.WriteLine($"Activity.TraceFlags: {activity.ActivityTraceFlags}");

• OpenTelemetrySdkEventSource does the slow path, but that's for a verbose-level trace message so I don't think we need to make it more performant.

  opentelemetry-dotnet/src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs

  Line 73 in 2435127

  var traceFlags = ((byte)activity.ActivityTraceFlags).ToString("x2", CultureInfo.InvariantCulture);

• B3 and Jaeger don't have any support for interpreting the W3C randomness flag so don't need changing